feat: enhance trusted commands system #2232
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 30, 2025 11:03
- Add conditional 'c' option for execute tools with context manager in confirmation prompts - Restore 't' option for non-execute tools (fs_write, use_aws, custom_tool) - Update trusted command pattern generation to use "git*" instead of "git *" format - Allow updating existing trusted command descriptions instead of throwing errors - Enhance trust display labels to distinguish between trust types: * "(trusted by user configuration)" for execute commands trusted via patterns * "(trusted - tool level)" for tools trusted via 't' option * "(trusted - all tools)" for global trust mode - Reorganize code structure by moving dangerous_patterns.rs and trusted_commands.rs to execute/ directory for better logical grouping - Update all tests to reflect new behavior and pattern formats - Suppress dead code warnings for test-only methods This improves the user experience by making trusted commands more intuitive, provides clearer feedback about trust sources, and organizes execute-related safety code in a more maintainable structure.
…on 'Exit rule creation and don't run any commands' to the interactive trusted command rule creation menu. This allows users to cancel both rule creation and command execution when prompted with the 'c' option. Changes: - Add option 5 to the interactive menu display - Update choice range from 1-4 to 1-5 in user prompt - Handle new exit option by returning to PromptUser state - Maintain existing behavior for options 1-4 (create rules or run command) The new option provides users with a clean way to exit the rule creation process without executing the command or creating any trusted command rules. Refactor duplicate code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
execute_bashgloballygit pushor deleting file)Related to
#1260 [RFC] Extra-granular Tool Permissions
This is a first step to implement this RFC.
Description of changes:
/tools allow execute_bashand/tools remove execute_bashcommandstoption to èxecute_bash` commandsPreview
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.