feat: Add OSC 9 terminal notifications with proper messaging #2868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement OSC 9 notification support for iTerm2 and Ghostty terminals - Add ASCII bell fallback for other compatible terminals - Show 'Amazon Q needs your attention' for tool confirmations - Show 'Amazon Q has completed its work' when tasks finish - Add configurable notifications via chat.enableNotifications setting - Include comprehensive documentation covering supported terminals, notification events, configuration, and technical implementation
|
This has considerable overlap with #2864 - but implements the functionality as a built-in part of QCLI, rather than as something the developer will add via a hook. I believe that this was also implemented as via hooks initially in Claude Code, but was so popular that it was rolled directly into the code, instead of relying on devs managing hooks and shell scripts. |
|
Also - I am not a rust developer, so this is all QCLIs work, with the idea and testing done by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #2867
Description of changes:
Added notification so that QCLI can get the users attention when it requires attention in the background using OSC 9 with modern terminals.
e.g.:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.