feat: add --no-banner option to disable ASCII logo display #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --no-banner CLI flag to ChatArgs - Update ChatSession to respect banner preference - Modify banner display logic to check both CLI flag and settings - Update all call sites and tests for compatibility - Maintain backward compatibility with existing behavior Usage: q chat --no-banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to disable the Q ASCII banner on startup, which allows a lot of user/tool flows to happen without messing up the output.
Issue: #2074
Description of changes:
feat: add --no-banner option to disable ASCII logo display
Usage:
q chat --no-bannerBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.