generated from amazon-archives/__template_Custom
-
Notifications
You must be signed in to change notification settings - Fork 351
feat(agent crate): adds remote mcp support in agent crate #3354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dingfeli
wants to merge
12
commits into
main
Choose a base branch
from
dingfeli/adds-http-support-agent-crate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b904dbb to
ff7b381
Compare
ff7b381 to
48336bf
Compare
48336bf to
8d60496
Compare
8d60496 to
960a9e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
McpServerActoris given ampsc::Sender<McpServerActorEvent>as opposed to eachMcpServerActorhaving to spawn their own pair. This is because this allows us to poll a singlempsc::Receiver<McpServerActorEvent>, as compared to before, where we have to callrecvon all of theMcpServerActorand putting them all a collectionimpl Future.Changes since review 1:
Tests
Test case: cached credentials, making tool calls (this was ran before the decoupling of Model from the agent crate):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.