feat(cli): add sts:TagSession permission to trusted accounts on bootstrap #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonu17
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 81.16% 81.21% +0.04%
==========================================
Files 61 61
Lines 8267 8267
Branches 952 950 -2
==========================================
+ Hits 6710 6714 +4
+ Misses 1529 1528 -1
+ Partials 28 25 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accounts bootstrapped with
--trustor--trust-for-lookupneedsts:TagSessionpermissions in AssumeRolePolicy.I got errors during
cdk deployrun in CD pipelines executed on EKS cluster on the trusted account.Error message:
Could not assume role in target account using current credentials (which are for account
<TRUSTED_ACCOUT>) User:arn:aws:sts::<TRUSTED_ACCOUT>:assumed-role/<eks-pod-role>is not authorized to perform:sts:TagSessionon resource:arn:aws:iam::<TARGET_ACCOUNT>:role/cdk-hnb659fds-lookup-role-<TARGET_ACCOUNT>-us-east-1Troubleshooting revealed that DeploymentActionRole, FilePublishingRole, ImagePublishingRole, LookupRole don't have
sts:TagSession. After updating AssumeRolePolicycdk deployworked normally.Fixes aws/aws-cdk#31557
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license