Skip to content

synthetics: add selenium runtime 5.0 and 5.1 #34252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 2 tasks
armujahid opened this issue Apr 25, 2025 · 3 comments · May be fixed by #34254
Open
1 of 2 tasks

synthetics: add selenium runtime 5.0 and 5.1 #34252

armujahid opened this issue Apr 25, 2025 · 3 comments · May be fixed by #34254
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@armujahid
Copy link

armujahid commented Apr 25, 2025

Describe the feature

syn-python-selenium-5.0 and syn-python-selenium-5.1 are now available but runtime options don't include these yet.
https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Library_python_selenium.html

Use Case

Unable to use synthetics.Runtime.SYNTHETICS_PYTHON_SELENIUM_5_0 and synthetics.Runtime.SYNTHETICS_PYTHON_SELENIUM_5_1 options while creating a canary.

Proposed Solution

Update canary Runtime options and add/update tests

Other Information

I might be able to implement this on my own.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.192.0

Environment details (OS name and version, etc.)

Linux

@armujahid armujahid added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 25, 2025
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Apr 25, 2025
@armujahid armujahid linked a pull request Apr 25, 2025 that will close this issue
1 task
@pahud
Copy link
Contributor

pahud commented Apr 25, 2025

Hi @armujahid,

Thanks for raising this feature request!

You are correct, the AWS Synthetics runtimes syn-python-selenium-5.0 and syn-python-selenium-5.1 are currently missing from the AWS CDK synthetics.Runtime options.

The necessary change involves adding these new runtime versions as static members to the Runtime class in packages/aws-cdk-lib/aws-synthetics/lib/runtime.ts, similar to how existing runtimes like SYNTHETICS_PYTHON_SELENIUM_4_1 are defined. Corresponding tests would also need to be added.

Since you mentioned you might be able to implement this, we would gladly welcome a Pull Request for this feature!

Let us know if you plan to work on this or have any questions!

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 25, 2025
@armujahid
Copy link
Author

@pahud please check comments at #34254
I have already done the changes but having issues with integration tests snapshot updates

@armujahid
Copy link
Author

Linked PR is ready for maintainer review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants