-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: property injection for 122 constructs #33887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…autoscaling, aws-backup, aws-cloudfront, aws-chatbot, aws-certificatemanager
…ws-docdb, aws-dynamodb
…s-iam, aws-kinesis
…searchservice, aws-rds
…ager, aws-stepfunctions-tasks, aws-servicecatalog, custom-resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
This is a preliminary PR to get early review on TODOs:
|
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
2 similar comments
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
…keCreateTrainingJob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting!
A lot of work in here applying these changes to all of those constructs, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @pcheungamz for implementing this feature .. I have some questions/comments about the L2 updates you did
1- Did you update all L2 constructs, and if yes, I assume you did not do it manually, if also yes, can I ask to push this script to be used as a GH action, so for future L2s, this change will be automatically applied.
2- Can you update the aws-cdk-lib/Readme file to add a new section explaining how this feature should be used. I believe we will also need some documentation updates to the CDK Docs
3- Can you add some integration test cases to https://github.com/aws/aws-cdk/tree/main/packages/%40aws-cdk-testing/framework-integ/test/core/test
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
2 similar comments
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state. |
This PR will make all L2 Constructs property injectable in the future: #34328. But it shouldn't block this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shipped then!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
This Implements the Property Injectors RFC. https://github.com/aws/aws-cdk-rfcs/blob/main/text/0693-property-injection.md
Reason for this change
Implement the Property Injectors feature so orgs can set up default Construct props values.
Description of changes
Key changes:
Describe any new or updated permissions being added
None
Description of how you validated changes
yarn package --target js
to create a library and write Injectors for Constructs.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license