-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: support healthCheckGracePeriod in QueueProcessingFargateService #34231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support healthCheckGracePeriod in QueueProcessingFargateService #34231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
7b968c9
to
bdd5249
Compare
Clarification Request: The PR linter is failing with
I've tried to satisfy this requirement, but the instructions in Here are the steps I went through:
The test failures suggest that the build is incomplete, despite me running the build command as described in |
Thanks @TrevorBurnham for submitting this PR, from your description of the error For successfully building the integration test with latest changes from aws-cdk lib, you can run |
a7056b1
to
0810eeb
Compare
fbcc2b2
to
f12fb56
Compare
@shikha372 Thank you! That command allowed me to run the integration test. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @TrevorBurnham for your contribution
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Closes #34220
Reason for this change
QueueProcessingFargateService
supports the ECS deployment circuit breaker, but doesn't currently offer any way to configure the health check grace period used by the circuit breaker, asFargateService
does. This PR rectifies that discrepancy.Description of changes
Added the
healthCheckGracePeriod
property toQueueProcessingFargateService
, matching the corresponding property onFargateService
.Describe any new or updated permissions being added
None.
Description of how you validated changes
I've added a unit test to verify that the property is passed to the underlying
FargateService
.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license