Skip to content

feat(events-targets): use IAM role for SnsTopic target #34259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+3,355 −3,039
Open

feat(events-targets): use IAM role for SnsTopic target #34259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9758aad
Let SnsTopic RuleTarget use IAM role
mellevanderlinde Apr 25, 2025
845a185
Update snapshot
mellevanderlinde Apr 25, 2025
115f2af
Add integ test with custom role attached to SnsTopic target
mellevanderlinde Apr 26, 2025
a5d51e1
Add README section for SnsTopic target
mellevanderlinde Apr 26, 2025
f3f2682
Add custom role example to README
mellevanderlinde Apr 26, 2025
c1cb212
Update integ snapshots
mellevanderlinde Apr 27, 2025
bd1861b
Fix README
mellevanderlinde Apr 27, 2025
0b1aaf6
Add unit test for multiple topics as targets
mellevanderlinde Apr 28, 2025
c250cb3
Merge branch 'main' into snstopic-role
mellevanderlinde Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...-actions/test/integ.pipeline-events.js.snapshot/aws-cdk-pipeline-event-target.assets.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

144 changes: 141 additions & 3 deletions ...ctions/test/integ.pipeline-events.js.snapshot/aws-cdk-pipeline-event-target.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,53 @@
"Arn": {
"Ref": "MyTopic86869434"
},
"Id": "Target0"
"Id": "Target0",
"RoleArn": {
"Fn::GetAtt": [
"MyPipelineSourceCodeCommitSourceOnActionStateChangeEventsRoleD56C86B6",
"Arn"
]
}
}
]
}
},
"MyPipelineSourceCodeCommitSourceOnActionStateChangeEventsRoleD56C86B6": {
"Type": "AWS::IAM::Role",
"Properties": {
"AssumeRolePolicyDocument": {
"Statement": [
{
"Action": "sts:AssumeRole",
"Effect": "Allow",
"Principal": {
"Service": "events.amazonaws.com"
}
}
],
"Version": "2012-10-17"
}
}
},
"MyPipelineSourceCodeCommitSourceOnActionStateChangeEventsRoleDefaultPolicy4701CFE4": {
"Type": "AWS::IAM::Policy",
"Properties": {
"PolicyDocument": {
"Statement": [
{
"Action": "sns:Publish",
"Effect": "Allow",
"Resource": {
"Ref": "MyTopic86869434"
}
}
],
"Version": "2012-10-17"
},
"PolicyName": "MyPipelineSourceCodeCommitSourceOnActionStateChangeEventsRoleDefaultPolicy4701CFE4",
"Roles": [
{
"Ref": "MyPipelineSourceCodeCommitSourceOnActionStateChangeEventsRoleD56C86B6"
}
]
}
Expand Down Expand Up @@ -554,7 +600,53 @@
"Arn": {
"Ref": "MyTopic86869434"
},
"Id": "Target0"
"Id": "Target0",
"RoleArn": {
"Fn::GetAtt": [
"MyPipelineSourceOnSourceStateChangeEventsRole79DEE677",
"Arn"
]
}
}
]
}
},
"MyPipelineSourceOnSourceStateChangeEventsRole79DEE677": {
"Type": "AWS::IAM::Role",
"Properties": {
"AssumeRolePolicyDocument": {
"Statement": [
{
"Action": "sts:AssumeRole",
"Effect": "Allow",
"Principal": {
"Service": "events.amazonaws.com"
}
}
],
"Version": "2012-10-17"
}
}
},
"MyPipelineSourceOnSourceStateChangeEventsRoleDefaultPolicy616A885B": {
"Type": "AWS::IAM::Policy",
"Properties": {
"PolicyDocument": {
"Statement": [
{
"Action": "sns:Publish",
"Effect": "Allow",
"Resource": {
"Ref": "MyTopic86869434"
}
}
],
"Version": "2012-10-17"
},
"PolicyName": "MyPipelineSourceOnSourceStateChangeEventsRoleDefaultPolicy616A885B",
"Roles": [
{
"Ref": "MyPipelineSourceOnSourceStateChangeEventsRole79DEE677"
}
]
}
Expand Down Expand Up @@ -670,11 +762,57 @@
"detail-state": "$.detail.state"
},
"InputTemplate": "\"Pipeline <detail-pipeline> changed state to <detail-state>\""
},
"RoleArn": {
"Fn::GetAtt": [
"MyPipelineOnPipelineStateChangeEventsRoleDFA9E661",
"Arn"
]
}
}
]
}
},
"MyPipelineOnPipelineStateChangeEventsRoleDFA9E661": {
"Type": "AWS::IAM::Role",
"Properties": {
"AssumeRolePolicyDocument": {
"Statement": [
{
"Action": "sts:AssumeRole",
"Effect": "Allow",
"Principal": {
"Service": "events.amazonaws.com"
}
}
],
"Version": "2012-10-17"
}
}
},
"MyPipelineOnPipelineStateChangeEventsRoleDefaultPolicy53C4E1C5": {
"Type": "AWS::IAM::Policy",
"Properties": {
"PolicyDocument": {
"Statement": [
{
"Action": "sns:Publish",
"Effect": "Allow",
"Resource": {
"Ref": "MyTopic86869434"
}
}
],
"Version": "2012-10-17"
},
"PolicyName": "MyPipelineOnPipelineStateChangeEventsRoleDefaultPolicy53C4E1C5",
"Roles": [
{
"Ref": "MyPipelineOnPipelineStateChangeEventsRoleDFA9E661"
}
]
}
},
"CodeCommitRepoDC6A41F9": {
"Type": "AWS::CodeCommit::Repository",
"Properties": {
Expand Down Expand Up @@ -921,4 +1059,4 @@
]
}
}
}
}
2 changes: 1 addition & 1 deletion ...mework-integ/test/aws-codepipeline-actions/test/integ.pipeline-events.js.snapshot/cdk.out
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions ...ork-integ/test/aws-codepipeline-actions/test/integ.pipeline-events.js.snapshot/integ.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading