chore: remove obsolete tslint disable comments#37358
Open
syukawa-gh wants to merge 1 commit intoaws:mainfrom
Open
chore: remove obsolete tslint disable comments#37358syukawa-gh wants to merge 1 commit intoaws:mainfrom
syukawa-gh wants to merge 1 commit intoaws:mainfrom
Conversation
TSLint has been replaced by ESLint. Remove the remaining tslint disable comments that are no longer needed.
github-actions
bot
added
p2
beginning-contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
TSLint has been replaced by ESLint in this project. A few leftover
tslint:disablecomments remain in the source code and serve no purpose.Description of changes
Remove 3 obsolete tslint disable comments from:
packages/aws-cdk-lib/aws-ec2/lib/vpc.ts—tslint:disable-next-line: max-line-lengthpackages/aws-cdk-lib/aws-ecs/lib/cluster.ts—tslint:disable-next-line: max-line-lengthpackages/@aws-cdk/aws-ec2-alpha/lib/util.ts—tslint:disable:no-bitwiseDescription of how you validated changes
Comment-only changes. No functional impact.
Checklist