[v2] Make inline docs scripts external #9594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kdaily The index.html file is from build, I accidentally included it in the PR, that commit is to remove the unintended file. The end result is as expected (index.html should not be committed). |
kdaily
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This change is in preparation for adding a
Content-Security-Policyheader to the AWS CLI API Reference versioned docs. The added header will block the loading of inline-scripts. To avoid breaking inline scripts on older versions of the docs, the header will allowlist these inline scripts. To avoid needing to update the header each time we modify these scripts in the future, we should move them to an external file.Description of changes:
Description of tests:
make allon the docs, and verified the scripts are being loaded.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.