-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Copy link
Labels
area/integration-testscontributors/welcomeContributors are welcome to work on thisContributors are welcome to work on thisstage/prHas a PR ready for reviewHas a PR ready for review
Description
When modifying integration tests recently, I noticed that the cryptography library had been removed as a dependency for our test applications in our integration tests (explanation here: #8549 (comment)). This was originally because of aws/aws-lambda-builders#29:
| # `cryptography` has a dependency on `pycparser` which, for some reason doesn't build inside a Docker container. | |
| # Turning this off until we resolve this issue: https://github.com/awslabs/aws-lambda-builders/issues/29 | |
| # cryptography~=2.4 |
However, that issue has been resolved now. It's probably safe to add cryptography back now, including to files that have been added since, such as https://github.com/aws/aws-sam-cli/blob/develop/tests/integration/testdata/buildcmd/PythonPyProject/pyproject.toml.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/integration-testscontributors/welcomeContributors are welcome to work on thisContributors are welcome to work on thisstage/prHas a PR ready for reviewHas a PR ready for review