Skip to content

Commit 15c4aaa

Browse files
authored
Fix HelpIds returning null in split plugin mode (#4253)
Help topic prefix defaults to the plugin identifier
1 parent f8811a9 commit 15c4aaa

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/help/HelpIdTranslator.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ import software.aws.toolkits.core.utils.getLogger
88
import software.aws.toolkits.core.utils.warn
99

1010
class HelpIdTranslator : WebHelpProvider() {
11+
override fun getHelpTopicPrefix() = HELP_ID_PREFIX
12+
1113
override fun getHelpPageUrl(helpTopicId: String) = HELP_REGISTRY.getOrElse(helpTopicId) {
1214
LOGGER.warn { "Missing id $helpTopicId" }
1315
DEFAULT_LOCATION

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/help/HelpIds.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,5 +127,7 @@ enum class HelpIds(shortId: String, val url: String) {
127127
)
128128
;
129129

130-
val id = "aws.toolkit.$shortId"
130+
val id = "$HELP_ID_PREFIX.$shortId"
131131
}
132+
133+
const val HELP_ID_PREFIX = "aws.toolkit"

0 commit comments

Comments
 (0)