Skip to content

Commit 245598d

Browse files
dhasani23David Hasani
andauthored
fix(amazonq): loosen search strings (#5260)
* fix(amazonq): loosen search strings * make field optional --------- Co-authored-by: David Hasani <davhasan@amazon.com>
1 parent 3e1e995 commit 245598d

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeModernizerManager.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ class CodeModernizerManager(private val project: Project) : PersistentStateCompo
164164
return if (javaModules.isNotEmpty()) {
165165
ValidationResult(
166166
true,
167+
metadata = "found ${javaModules.size} modules with SQL"
167168
)
168169
} else {
169170
ValidationResult(

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/CodeTransformTelemetryManager.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ class CodeTransformTelemetryManager(private val project: Project) {
5858
codeTransformPreValidationError = validationError,
5959
codeTransformBuildSystem = validationResult.buildSystem,
6060
codeTransformSessionId = sessionId,
61+
codeTransformMetadata = validationResult.metadata,
6162
result = if (validationResult.valid) Result.Succeeded else Result.Failed,
6263
reason = if (validationResult.valid) null else validationResult.invalidTelemetryReason.additionalInfo,
6364
)

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/ValidationResult.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,12 @@ package software.aws.toolkits.jetbrains.services.codemodernizer.model
66
import com.intellij.openapi.vfs.VirtualFile
77
import software.aws.toolkits.telemetry.CodeTransformBuildSystem
88

9+
// TODO: combine a lot of these fields into the 'metadata' field
910
data class ValidationResult(
1011
val valid: Boolean,
1112
val invalidTelemetryReason: InvalidTelemetryReason = InvalidTelemetryReason(),
1213
val validatedBuildFiles: List<VirtualFile> = emptyList(),
1314
val buildSystem: CodeTransformBuildSystem = CodeTransformBuildSystem.Unknown,
1415
val buildSystemVersion: String = "",
16+
val metadata: String? = null,
1517
)

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/utils/CodeTransformModuleUtils.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,8 @@ fun Module.tryGetJdkLanguageLevelJdk(): JavaSdkVersion? {
4444
// search for Strings that indicate embedded Oracle SQL statements are present
4545
fun containsSQL(contentRoot: VirtualFile): Boolean {
4646
val patterns = listOf(
47-
"oracle.jdbc.OracleDriver",
48-
"jdbc:oracle:thin:@",
49-
"jdbc:oracle:oci:@",
47+
"oracle.jdbc.",
48+
"jdbc:oracle:",
5049
"jdbc:odbc:",
5150
)
5251

0 commit comments

Comments
 (0)