update assertions for tests: remove explicitly logging failed results

Author: Gaurav Gandhi

ui-tests-starter/tst-243+/software/aws/toolkits/jetbrains/uitests/docTests/createReadmeTests/CreateReadmeTest.kt

@@ -280,11 +280,8 @@ class CreateReadmeTest {
                 assertThat(readme).doesNotExist()
 
                 val result = executePuppeteerScript(newReadmeDiffViewerTestScript)
-                assertThat(result).doesNotContain("Error: Test Failed")
-
-                if (result.contains("Error: Test Failed")) {
-                    println("result: $result")
-                }
+                assertThat(result)
+                    .doesNotContain("Error: Test Failed")
 
                 val panel = this.ui.x("//div[contains(@class, 'SimpleDiffPanel')]")
                 assertThat(panel.present()).isTrue()

ui-tests-starter/tst-243+/software/aws/toolkits/jetbrains/uitests/docTests/createReadmeTests/CreateReadmeWorkspacesTest.kt

@@ -89,14 +89,15 @@ class CreateReadmeWorkspacesTest {
                 assertThat(readme).doesNotExist()
 
                 val result = executePuppeteerScript(acceptReadmeTestScript)
-                assertThat(result).doesNotContain("Error: Test Failed")
-                if (result.contains("Error: Test Failed")) {
-                    println("result: $result")
-                }
+                assertThat(result)
+                    .doesNotContain("Error: Test Failed")
 
                 val newReadmePath = Paths.get("tstData", "qdoc", "createFlow", "README.md")
                 val newReadme = File(newReadmePath.toUri())
-                assertThat(newReadme).exists().content().contains("REST", "API")
+                assertThat(newReadme)
+                    .exists()
+                    .content()
+                    .contains("REST", "API")
             }
     }
 
@@ -129,25 +130,24 @@ class CreateReadmeWorkspacesTest {
 
                 val readmePath = Paths.get("tstData", "qdoc", "createFlow", "src", "README.md")
                 val readme = File(readmePath.toUri())
-                assertThat(readme).doesNotExist()
+                assertThat(readme)
+                    .doesNotExist()
 
                 val result = executePuppeteerScript(createReadmeSubFolderPreFolderChangeTestScript)
                 this.ui.robot.pressAndReleaseKey(KeyEvent.VK_RIGHT)
                 this.ui.robot.enterText("\\/src")
                 this.ui.robot.pressAndReleaseKey(KeyEvent.VK_ENTER)
                 val result2 = executePuppeteerScript(createReadmeSubFolderPostFolderChangeTestScript)
 
-                assertThat(result).doesNotContain("Error: Test Failed")
-                assertThat(result2).doesNotContain("Error: Test Failed")
-
-                if (result.contains("Error: Test Failed") || result2.contains("Error: Test Failed")) {
-                    println("result: $result")
-                    println("result2: $result2")
-                }
+                assertThat(result)
+                    .doesNotContain("Error: Test Failed")
+                assertThat(result2)
+                    .doesNotContain("Error: Test Failed")
 
                 val newReadmePath = Paths.get("tstData", "qdoc", "createFlow", "src", "README.md")
                 val newReadme = File(newReadmePath.toUri())
-                assertThat(newReadme).exists()
+                assertThat(newReadme)
+                    .exists()
             }
     }
 
@@ -183,14 +183,13 @@ class CreateReadmeWorkspacesTest {
                 assertThat(readme).doesNotExist()
 
                 val result = executePuppeteerScript(acceptReadmeTestScript)
-                assertThat(result).doesNotContain("Error: Test Failed")
-                if (result.contains("Error: Test Failed")) {
-                    println("result: $result")
-                }
+                assertThat(result)
+                    .doesNotContain("Error: Test Failed")
 
                 val newReadmePath = Paths.get("tstData", "qdoc", "README.md")
                 val newReadme = File(newReadmePath.toUri())
-                assertThat(newReadme).exists()
+                assertThat(newReadme)
+                    .exists()
                     .content()
                     .contains(
                         "REST",