fix detekt and test

Author: David Hasani

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/controller/CodeTransformChatController.kt

@@ -4,17 +4,21 @@
 package software.aws.toolkits.jetbrains.services.codemodernizer.controller
 
 import com.intellij.ide.BrowserUtil
+import com.intellij.openapi.application.ApplicationManager
 import com.intellij.openapi.application.runInEdt
 import com.intellij.openapi.fileChooser.FileChooser
 import com.intellij.openapi.fileChooser.FileChooserDescriptorFactory
+import com.intellij.openapi.fileEditor.FileEditorManager
 import com.intellij.openapi.module.ModuleUtil
 import com.intellij.openapi.projectRoots.JavaSdkVersion
 import com.intellij.openapi.projectRoots.ProjectJdkTable
 import com.intellij.openapi.util.io.FileUtil.createTempDirectory
 import com.intellij.openapi.vfs.VirtualFile
+import com.intellij.testFramework.LightVirtualFile
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.runBlocking
 import kotlinx.coroutines.withContext
+import org.jetbrains.yaml.YAMLFileType
 import software.amazon.awssdk.services.codewhispererstreaming.model.TransformationDownloadArtifactType
 import software.aws.toolkits.core.utils.debug
 import software.aws.toolkits.core.utils.error
@@ -127,10 +131,6 @@ import software.aws.toolkits.jetbrains.services.codewhisperer.telemetry.broadcas
 import software.aws.toolkits.jetbrains.services.cwc.messages.ChatMessageType
 import software.aws.toolkits.resources.message
 import software.aws.toolkits.telemetry.CodeTransformPreValidationError
-import com.intellij.openapi.application.ApplicationManager
-import com.intellij.openapi.fileEditor.FileEditorManager
-import com.intellij.testFramework.LightVirtualFile
-import org.jetbrains.yaml.YAMLFileType
 
 class CodeTransformChatController(
     private val context: AmazonQAppInitContext,

plugins/amazonq/codetransform/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codemodernizer/ideMaven/MavenRunnerUtils.kt

@@ -96,7 +96,7 @@ private fun runMavenJar(
     val jarPath = AwsToolkit.PLUGINS_INFO[AwsPlugin.Q]?.path?.resolve("lib/QCT-Maven.jar")
 
     val commandList = listOf(
-        "-Dmaven.ext.class.path=${jarPath}",
+        "-Dmaven.ext.class.path=$jarPath",
         "-Dcom.amazon.aws.developer.transform.jobDirectory=$destinationDir",
         "clean",
         "test-compile"

plugins/amazonq/codetransform/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/codemodernizer/CodeWhispererCodeModernizerSessionTest.kt

@@ -166,12 +166,11 @@ class CodeWhispererCodeModernizerSessionTest : CodeWhispererCodeModernizerTestBa
                         assertThat(fileContent).contains(MAVEN_BUILD_SKIP_UNIT_TESTS)
                     }
                     Path("sources/src/tmp.txt") -> assertThat(fileContent).isEqualTo(fileText)
-                    Path("build-logs.txt") -> assertThat(fileContent).isNotNull()
                     else -> fail("Unexpected entry in zip file: $entry")
                 }
             }
             zipFile.close()
-            assert(numEntries == 3)
+            assert(numEntries == 2)
         }
     }
 
@@ -205,7 +204,6 @@ class CodeWhispererCodeModernizerSessionTest : CodeWhispererCodeModernizerTestBa
                     Path("manifest.json") -> assertThat(fileContent).isNotNull()
                     Path("sources/src/tmp.java") -> assertThat(fileContent).isEqualTo(fileText)
                     Path("sources/pom.xml") -> assertThat(fileContent).isEqualTo(fileText)
-                    Path("build-logs.txt") -> assertThat(fileContent).isNotNull()
                     else -> fail("Unexpected entry in zip file: $entry")
                 }
             }
@@ -242,7 +240,6 @@ class CodeWhispererCodeModernizerSessionTest : CodeWhispererCodeModernizerTestBa
                     Path("manifest.json") -> assertThat(fileContent).isNotNull()
                     Path("sources/src/tmp.java") -> assertThat(fileContent).isEqualTo(fileText)
                     Path("sources/pom.xml") -> assertThat(fileContent).isEqualTo(fileText)
-                    Path("build-logs.txt") -> assertThat(fileContent).isNotNull()
                     else -> fail("Unexpected entry in zip file: $entry")
                 }
             }
@@ -282,7 +279,6 @@ class CodeWhispererCodeModernizerSessionTest : CodeWhispererCodeModernizerTestBa
                     Path("sources/pom.xml") -> assertThat(fileContent).isEqualTo("pom.xml")
                     Path("sources/someModule/src/helloworld.java") -> assertThat(fileContent).isEqualTo("someModule/src/helloworld.java")
                     Path("sources/someModule/pom.xml") -> assertThat(fileContent).isEqualTo("someModule/pom.xml")
-                    Path("build-logs.txt") -> assertThat(fileContent).isNotNull()
                     else -> fail("Unexpected entry in zip file: $entry")
                 }
             }
@@ -322,7 +318,6 @@ class CodeWhispererCodeModernizerSessionTest : CodeWhispererCodeModernizerTestBa
                     Path("sources/pom.xml") -> assertThat(fileContent).isEqualTo("pom.xml")
                     Path("sources/someModule/src/helloworld.java") -> assertThat(fileContent).isEqualTo("someModule\\src\\helloworld.java")
                     Path("sources/someModule/pom.xml") -> assertThat(fileContent).isEqualTo("someModule\\pom.xml")
-                    Path("build-logs.txt") -> assertThat(fileContent).isNotNull()
                     else -> fail("Unexpected entry in zip file: $entry")
                 }
             }
@@ -360,7 +355,6 @@ class CodeWhispererCodeModernizerSessionTest : CodeWhispererCodeModernizerTestBa
                     Path("sources/pom.xml") -> assertThat(fileContent).isEqualTo("pom.xml")
                     Path("sources/src/tmp.java") -> assertThat(fileContent).isEqualTo("src/tmp.java")
                     Path("sources/someModule/pom.xml") -> assertThat(fileContent).isEqualTo("someModule/pom.xml")
-                    Path("build-logs.txt") -> assertThat(fileContent).isNotNull()
                     else -> throw AssertionError("Unexpected entry in zip file: $entry")
                 }
             }