Skip to content

Commit 79d4221

Browse files
authored
Q Developer: Remove logging on non-existent files. (#4506)
1 parent bb92d0b commit 79d4221

File tree

2 files changed

+3
-16
lines changed

2 files changed

+3
-16
lines changed

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/codescan/listeners/CodeWhispererCodeScanDocumentListener.kt

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import com.intellij.openapi.editor.event.DocumentListener
88
import com.intellij.openapi.fileEditor.FileDocumentManager
99
import com.intellij.openapi.project.Project
1010
import com.intellij.openapi.util.TextRange
11-
import software.aws.toolkits.core.utils.error
12-
import software.aws.toolkits.core.utils.getLogger
1311
import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.CodeWhispererCodeScanIssue
1412
import software.aws.toolkits.jetbrains.services.codewhisperer.codescan.CodeWhispererCodeScanManager
1513
import software.aws.toolkits.jetbrains.services.codewhisperer.explorer.CodeWhispererExplorerActionManager
@@ -20,13 +18,10 @@ import javax.swing.tree.TreePath
2018
internal class CodeWhispererCodeScanDocumentListener(val project: Project) : DocumentListener {
2119

2220
override fun documentChanged(event: DocumentEvent) {
21+
val file = FileDocumentManager.getInstance().getFile(event.document) ?: return
2322
val scanManager = CodeWhispererCodeScanManager.getInstance(project)
2423
val treeModel = scanManager.getScanTree().model
25-
val file = FileDocumentManager.getInstance().getFile(event.document)
26-
if (file == null) {
27-
LOG.error { "Cannot find file for document ${event.document}" }
28-
return
29-
}
24+
3025
val editedTextRange = TextRange.create(event.offset, event.offset + event.oldLength)
3126
val nodes = scanManager.getOverlappingScanNodes(file, editedTextRange)
3227
nodes.forEach {
@@ -43,8 +38,4 @@ internal class CodeWhispererCodeScanDocumentListener(val project: Project) : Doc
4338
scanManager.createDebouncedRunCodeScan(CodeWhispererConstants.CodeAnalysisScope.FILE)
4439
}
4540
}
46-
47-
companion object {
48-
private val LOG = getLogger<CodeWhispererCodeScanDocumentListener>()
49-
}
5041
}

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/codescan/listeners/CodeWhispererCodeScanEditorMouseMotionListener.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -361,11 +361,7 @@ class CodeWhispererCodeScanEditorMouseMotionListener(private val project: Projec
361361
return
362362
}
363363
val offset = e.offset
364-
val file = FileDocumentManager.getInstance().getFile(e.editor.document)
365-
if (file == null) {
366-
LOG.error { "Cannot find file for the document ${e.editor.document}" }
367-
return
368-
}
364+
val file = FileDocumentManager.getInstance().getFile(e.editor.document) ?: return
369365
val issuesInRange = scanManager.getScanNodesInRange(file, offset).map {
370366
it.userObject as CodeWhispererCodeScanIssue
371367
}

0 commit comments

Comments
 (0)