Skip to content

Commit 9e3760e

Browse files
authored
fix infinite service call of sendUserModification on failure (#5350)
* remove service call within catch block
1 parent fd95bc1 commit 9e3760e

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ class CodeWhispererUserModificationTracker(private val project: Project) : Dispo
135135
}
136136

137137
private fun emitTelemetryOnChatCodeInsert(insertedCode: InsertedCodeModificationEntry) {
138-
try {
138+
val modificationPercentage = try {
139139
val file = insertedCode.vFile
140140
if (file == null || (!file.isValid)) throw Exception("Record OnChatCodeInsert - invalid file")
141141

@@ -145,11 +145,12 @@ class CodeWhispererUserModificationTracker(private val project: Project) : Dispo
145145
val currentString = document?.getText(
146146
TextRange(insertedCode.range.startOffset, insertedCode.range.endOffset)
147147
)
148-
val modificationPercentage = checkDiff(currentString?.trim(), insertedCode.originalString.trim())
149-
sendModificationWithChatTelemetry(insertedCode, modificationPercentage)
148+
checkDiff(currentString?.trim(), insertedCode.originalString.trim())
150149
} catch (e: Exception) {
151-
sendModificationWithChatTelemetry(insertedCode, null)
150+
null
152151
}
152+
153+
sendModificationWithChatTelemetry(insertedCode, modificationPercentage)
153154
}
154155

155156
private fun emitTelemetryOnSuggestion(acceptedSuggestion: AcceptedSuggestionEntry) {

0 commit comments

Comments
 (0)