Skip to content

Commit bd0261a

Browse files
authored
Fix flaky test mavenRootPomHandlerBaseDirIsCorrect (#4452)
* identify flaky tests * bumb kotlinCoroutines version * changed to runBlocking * added comments
1 parent 051d0c5 commit bd0261a

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

plugins/toolkit/jetbrains-core/tst/software/aws/toolkits/jetbrains/services/lambda/java/JavaLambdaBuilderTest.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import com.intellij.openapi.module.ModuleManager
77
import com.intellij.openapi.roots.ModuleRootManagerEx
88
import com.intellij.openapi.roots.ModuleRootModificationUtil
99
import com.intellij.testFramework.IdeaTestUtil
10-
import kotlinx.coroutines.test.runTest
10+
import kotlinx.coroutines.runBlocking
1111
import org.assertj.core.api.Assertions.assertThat
1212
import org.assertj.core.api.Assertions.assertThatThrownBy
1313
import org.junit.Before
@@ -60,8 +60,10 @@ class JavaLambdaBuilderTest {
6060
assertThat(baseDir.toAbsolutePath()).isEqualTo(Paths.get(moduleRoot, SamCommon.SAM_BUILD_DIR, "build"))
6161
}
6262

63+
// Using runBlocking instead runTest because there is issue with runTest and the fix is in a later version of coroutines-test
64+
// [#3800] (https://github.com/Kotlin/kotlinx.coroutines/issues/3800)
6365
@Test
64-
fun mavenRootPomHandlerBaseDirIsCorrect() = runTest {
66+
fun mavenRootPomHandlerBaseDirIsCorrect(): Unit = runBlocking {
6567
val psiClass = projectRule.setUpMavenProject()
6668

6769
val module = ModuleManager.getInstance(projectRule.project).modules.first()
@@ -71,7 +73,7 @@ class JavaLambdaBuilderTest {
7173
}
7274

7375
@Test
74-
fun mavenRootPomBuildDirectoryIsCorrect() = runTest {
76+
fun mavenRootPomBuildDirectoryIsCorrect(): Unit = runBlocking {
7577
projectRule.setUpMavenProject()
7678

7779
val module = ModuleManager.getInstance(projectRule.project).modules.first()

0 commit comments

Comments
 (0)