fix(/dev): remove telemetry verification as it is no-op

Author: sannicm

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevConstants.kt

@@ -17,7 +17,7 @@ const val DEFAULT_RETRY_LIMIT = 0
 // Max allowed size for a repository in bytes
 const val MAX_PROJECT_SIZE_BYTES: Long = 200 * 1024 * 1024
 
-enum class ModifySourceFolderReason(
+enum class ModifySourceFolderErrorReason(
     private val reasonText: String
 ) {
     ClosedBeforeSelection("ClosedBeforeSelection"),

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt

@@ -31,7 +31,7 @@ import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.CodeIterationL
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.DEFAULT_RETRY_LIMIT
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FEATURE_NAME
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.InboundAppMessagesHandler
-import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.ModifySourceFolderReason
+import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.ModifySourceFolderErrorReason
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.MonthlyConversationLimitError
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.PlanIterationLimitError
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.createUserFacingErrorMessage
@@ -612,7 +612,7 @@ class FeatureDevController(
         )
 
         var result: Result = Result.Failed
-        var reason: ModifySourceFolderReason? = null
+        var reason: ModifySourceFolderErrorReason? = null
 
         withContext(EDT) {
             val selectedFolder = selectFolder(context.project, currentSourceFolder)
@@ -625,7 +625,7 @@ class FeatureDevController(
                     followUp = listOf(modifyFolderFollowUp),
                 )
 
-                reason = ModifySourceFolderReason.ClosedBeforeSelection
+                reason = ModifySourceFolderErrorReason.ClosedBeforeSelection
                 return@withContext
             }
 
@@ -644,7 +644,7 @@ class FeatureDevController(
                     followUp = listOf(modifyFolderFollowUp),
                 )
 
-                reason = ModifySourceFolderReason.NotInWorkspaceFolder
+                reason = ModifySourceFolderErrorReason.NotInWorkspaceFolder
                 return@withContext
             }
 

plugins/amazonq/chat/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerTest.kt

@@ -35,7 +35,6 @@ import software.aws.toolkits.jetbrains.services.amazonq.auth.AuthController
 import software.aws.toolkits.jetbrains.services.amazonq.auth.AuthNeededStates
 import software.aws.toolkits.jetbrains.services.amazonq.messages.MessagePublisher
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FeatureDevTestBase
-import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.ModifySourceFolderReason
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.clients.FeatureDevClient
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.FeatureDevMessageType
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.FollowUp
@@ -62,7 +61,6 @@ import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.selectFol
 import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.uploadArtifactToS3
 import software.aws.toolkits.resources.message
 import software.aws.toolkits.telemetry.AmazonqTelemetry
-import software.aws.toolkits.telemetry.Result
 import org.mockito.kotlin.verify as mockitoVerify
 
 class FeatureDevControllerTest : FeatureDevTestBase() {
@@ -407,9 +405,6 @@ class FeatureDevControllerTest : FeatureDevTestBase() {
         whenever(featureDevClient.createTaskAssistConversation()).thenReturn(exampleCreateTaskAssistConversationResponse)
         whenever(chatSessionStorage.getSession(any(), any())).thenReturn(spySession)
 
-        mockkObject(AmazonqTelemetry)
-        every { AmazonqTelemetry.modifySourceFolder(amazonqConversationId = any()) } just runs
-
         mockkStatic("software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.FileUtilsKt")
         every { selectFolder(any(), any()) } returns null
 
@@ -427,13 +422,6 @@ class FeatureDevControllerTest : FeatureDevTestBase() {
                     )
                 )
             )
-            AmazonqTelemetry.modifySourceFolder(
-                amazonqConversationId = spySession.conversationId,
-                credentialStartUrl = any(),
-                result = Result.Failed,
-                reason = ModifySourceFolderReason.ClosedBeforeSelection.toString(),
-                createTime = any()
-            )
         }
     }
 
@@ -445,9 +433,6 @@ class FeatureDevControllerTest : FeatureDevTestBase() {
         whenever(featureDevClient.createTaskAssistConversation()).thenReturn(exampleCreateTaskAssistConversationResponse)
         whenever(chatSessionStorage.getSession(any(), any())).thenReturn(spySession)
 
-        mockkObject(AmazonqTelemetry)
-        every { AmazonqTelemetry.modifySourceFolder(amazonqConversationId = any()) } just runs
-
         mockkStatic("software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.FileUtilsKt")
         every { selectFolder(any(), any()) } returns LightVirtualFile("/path")
 
@@ -470,13 +455,6 @@ class FeatureDevControllerTest : FeatureDevTestBase() {
                     )
                 )
             )
-            AmazonqTelemetry.modifySourceFolder(
-                amazonqConversationId = spySession.conversationId,
-                credentialStartUrl = any(),
-                result = Result.Failed,
-                reason = ModifySourceFolderReason.NotInWorkspaceFolder.toString(),
-                createTime = any()
-            )
         }
     }
 
@@ -488,9 +466,6 @@ class FeatureDevControllerTest : FeatureDevTestBase() {
         whenever(featureDevClient.createTaskAssistConversation()).thenReturn(exampleCreateTaskAssistConversationResponse)
         whenever(chatSessionStorage.getSession(any(), any())).thenReturn(spySession)
 
-        mockkObject(AmazonqTelemetry)
-        every { AmazonqTelemetry.modifySourceFolder(amazonqConversationId = any()) } just runs
-
         val folder = LightVirtualFile("${spySession.context.projectRoot.name}/path/to/sub/folder")
         mockkStatic("software.aws.toolkits.jetbrains.services.amazonqFeatureDev.util.FileUtilsKt")
         every { selectFolder(any(), any()) } returns folder
@@ -504,13 +479,6 @@ class FeatureDevControllerTest : FeatureDevTestBase() {
                 messageType = FeatureDevMessageType.Answer,
                 message = message("amazonqFeatureDev.follow_up.modified_source_folder", folder.path)
             )
-            AmazonqTelemetry.modifySourceFolder(
-                amazonqConversationId = spySession.conversationId,
-                credentialStartUrl = any(),
-                result = Result.Succeeded,
-                reason = isNull(),
-                createTime = any()
-            )
         }
     }
 }