Adding featureDevSessionContext back for more rigorous file ignore in… #4516
Conversation
… payload creation.
| runBlocking { !featureDevSessionContext.ignoreFile(current, this) } && | ||
| !files.contains(current.path) |
There was a problem hiding this comment.
please confirm there is no regression for large project trees
There was a problem hiding this comment.
still unclear why we can't start converging implementations #4471
There was a problem hiding this comment.
We have different implementations for iterating through files(we need changeListManager which is not setup in 4471), different project size limits. So not sure about merging both implementations. But if other teams are ok with using changeListManager along with existing ignore setup, then I can try merging implementations.
There was a problem hiding this comment.
Coming to regression....there is some slow down in file collection time.
|
… payload creation.
Types of changes
Problem: Customers seeing cases of gitignore files getting into file payload.
Solution: Currently chnageListManager seems to be not totally reliable, so adding back featureDevSessionContext back to do more rigorous file ignore check.
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.