Skip to content

Adding featureDevSessionContext back for more rigorous file ignore in… #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2024

Conversation

ashishrp-aws
Copy link
Contributor

… payload creation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
    Problem: Customers seeing cases of gitignore files getting into file payload.
    Solution: Currently chnageListManager seems to be not totally reliable, so adding back featureDevSessionContext back to do more rigorous file ignore check.

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested a review from a team as a code owner May 25, 2024 01:32
Comment on lines +159 to +160
runBlocking { !featureDevSessionContext.ignoreFile(current, this) } &&
!files.contains(current.path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please confirm there is no regression for large project trees

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still unclear why we can't start converging implementations #4471

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have different implementations for iterating through files(we need changeListManager which is not setup in 4471), different project size limits. So not sure about merging both implementations. But if other teams are ok with using changeListManager along with existing ignore setup, then I can try merging implementations.

Copy link
Contributor Author

@ashishrp-aws ashishrp-aws May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming to regression....there is some slow down in file collection time.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@ashishrp-aws ashishrp-aws merged commit cfdf936 into aws:main May 30, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants