Upgrade IntelliJ Platform Gradle Plugin to 2.0 #4524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/explorer/nodes/ResumeCodeScanNode.kt
This reverts commit d4ca41a.
manodnyab
reviewed
Jun 25, 2024
| @@ -32,7 +32,7 @@ allprojects { | |||
| configurations.all { | |||
| resolutionStrategy { | |||
| failOnDynamicVersions() | |||
| failOnChangingVersions() | |||
| // failOnChangingVersions() | |||
There was a problem hiding this comment.
nit: do we need this or can be deleted?
There was a problem hiding this comment.
ideally we keep this, not sure if we can yet
* Improving telemetry error messages * Adding reasonDesc param to telemetry error messages
Rewrite integration with the New Solution dialog in Rider to use the new API. Without this, in 2024.1 the plugin won't provide any extension for the New Solution dialog. Co-authored-by: Richard Li <742829+rli@users.noreply.github.com>
Sometimes we get exactly 5 failing flaky tests
|
manodnyab
approved these changes
Jun 27, 2024
| - su codebuild-user -c "./gradlew -PideProfileName=$ALTERNATIVE_IDE_PROFILE_NAME check coverageReport --info --console plain --continue" | ||
| - ./gradlew -PideProfileName=$ALTERNATIVE_IDE_PROFILE_NAME :plugin-toolkit:intellij-standalone:buildPlugin :plugin-core:buildPlugin :plugin-amazonq:buildPlugin | ||
| - su codebuild-user -c "./gradlew -PideProfileName=$ALTERNATIVE_IDE_PROFILE_NAME check coverageReport --info --console plain --continue -scan" | ||
| - ./gradlew -PideProfileName=$ALTERNATIVE_IDE_PROFILE_NAME :plugin-toolkit:intellij-standalone:buildPlugin :plugin-core:buildPlugin :plugin-amazonq:buildPlugin :plugin-toolkit:intellij-standalone:verifyPlugin :plugin-core:verifyPlugin :plugin-amazonq:verifyPlugin |
There was a problem hiding this comment.
is verifyPlugin running more tests than check?
There was a problem hiding this comment.
the new behavior appears to spin up multiple IDE instances and we run out of RAM in the build container
| .executeInBackground( | ||
| object : ProcessListener { | ||
| override fun startNotified(event: ProcessEvent) { | ||
| println("ssh client: startNotified") |
There was a problem hiding this comment.
Are these print statements required?
There was a problem hiding this comment.
trying to understand the random failure in windows for this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for 2024.2 support
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.