fix(amazonq): auto scan use unsaved content #4527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishrp-aws
approved these changes
May 30, 2024
|
/retryBuilds |
ashishrp-aws
reviewed
Jun 3, 2024
...ws/toolkits/jetbrains/services/codewhisperer/codescan/sessionconfig/CodeScanSessionConfig.kt
Outdated
Show resolved
Hide resolved
|
Can we add tests? |
ashishrp-aws
reviewed
Jun 5, 2024
| private fun zipFile(filePath: Path): File = createTemporaryZipFile { | ||
| try { | ||
| val relativePath = filePath.relativeTo(projectRoot.toNioPath()) | ||
| val virtualFile = VirtualFileManager.getInstance().findFileByNioPath(filePath) |
There was a problem hiding this comment.
these two lines are error prone in case of remote development cases. i'll make the changes for these two once i complete testing for remote cases.
There was a problem hiding this comment.
Discussed offline, this will be addressed in a separate PR
ashishrp-aws
approved these changes
Jun 5, 2024
manodnyab
approved these changes
Jun 6, 2024
ashishrp-aws
approved these changes
Jun 6, 2024
|
/retryBuilds |
|
ashishrp-aws
added a commit
to ashishrp-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jul 12, 2024
… for ZipOutputStream using bufferedStream instead of bytes array. This reverts commit 8c109af.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problem
Zip file artifact created from auto scans don't have the latest text document content because we are reading the file contents from disk. This means auto scans are never scanning the latest version of the content.
Solution
Get the file contents from
FileDocumentManagerwhich has the latest changes and write that to the zip file instead of relying on file path / reading from disk.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.