Skip to content

fix(featureDev): File Rejection stopped working (with plan not disappearing on clicking Generate Code) #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2024

Conversation

dianaabv16
Copy link
Contributor

The plan disappears after clicking generate Code

This is a critical bug for featureDev.
How it was fixed:
Initially, 'ANSWER_STREAM' card is created (with a loading animation). When the plan content is ready, the card type is updated to 'ANSWER'. This prevents the updateLastChatAnswer method from catching and updating the card, allowing the complete plan content to be displayed correctly.

What is being fixed:

Plan is shown at all times

Note:

File rejection is still in place
Screenshot 2024-05-30 at 14 45 19 Screenshot 2024-05-30 at 14 43 42

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dianaabv16 dianaabv16 requested a review from a team as a code owner May 30, 2024 12:52
@dianaabv16 dianaabv16 changed the title fix(featureDev): File Rejection stopped working fix(featureDev): File Rejection stopped working (with plan no disappearing on clicking Generate Code) May 30, 2024
@dianaabv16 dianaabv16 changed the title fix(featureDev): File Rejection stopped working (with plan no disappearing on clicking Generate Code) fix(featureDev): File Rejection stopped working (with plan not disappearing on clicking Generate Code) May 30, 2024
Copy link
Contributor

@rli rli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

@dianaabv16 dianaabv16 requested a review from a team as a code owner May 30, 2024 13:28
@dianaabv16
Copy link
Contributor Author

added changelog

@dianaabv16
Copy link
Contributor Author

/retryBuilds

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dianaabv16 dianaabv16 merged commit 82a818a into aws:main May 30, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants