Skip to content

Amazon Q Code Transform: Improve download error handling ux #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

tincheng
Copy link
Contributor

@tincheng tincheng commented May 30, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Show errors in Code Transform chat panel when encountering download errors.
  • Remove redundant download error notification.

image

image

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tincheng tincheng requested review from a team as code owners May 30, 2024 17:52
@@ -457,6 +465,11 @@ class CodeTransformChatController(
}
}

private suspend fun handleDownloadFailed(failureReason: DownloadFailureReason) {
codeTransformChatHelper.addNewMessage(buildDownloadFailureChatContent(failureReason))
codeTransformChatHelper.addNewMessage(buildStartNewTransformFollowup())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker: How many failure functions call buildStartNewTransformFollowup? 6-7?

Its out of scope for this PR, but would be a nice to have this abstracted so any failure state that calls buildStartNewTransformFollowup goes through a single function.

@tincheng tincheng enabled auto-merge (squash) June 3, 2024 16:08
@tincheng tincheng requested a review from manodnyab June 3, 2024 18:26
Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tincheng tincheng merged commit aa588b4 into aws:main Jun 4, 2024
9 of 11 checks passed
@tincheng tincheng deleted the chat_improvement branch June 4, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants