Skip to content

fix(amazonq): Automatic start workspace indexing for new project open #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Sep 11, 2024

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented Sep 3, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

In the current release, the workspace indexing only starts when user input workspace in the chat window, which will fail the first query with workspace for customers because the service is not ready customer will still see responses that is not context aware. This is a bug and in VS Code Amazon Q we do not have such bug, the indexing starts when a new project is opened.

The solution is to start the workspace indexing when user opens a new project with a small delay and conditions. We are aware of the native intelliJ indexing and other possible CPU heavy computation when JetBrains loads a new project, so we added conditions to wait until the CPU usage is low enough to do workspace indexing without slowing down the device.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required) ---> Indexing time is already in the metrics.

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners September 3, 2024 21:09
@rli
Copy link
Contributor

rli commented Sep 3, 2024

@workspace needs to be escaped because there is a github user of the same name

@leigaol leigaol changed the title fix(amazonq): Automatic start @workspace indexing for new project open fix(amazonq): Automatic start workspace indexing for new project open Sep 3, 2024
@Will-ShaoHua Will-ShaoHua self-requested a review September 10, 2024 22:57
@leigaol leigaol merged commit 340bd34 into aws:main Sep 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants