-
Notifications
You must be signed in to change notification settings - Fork 253
fix(amazonq): Automatic start workspace indexing for new project open #4858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rli
reviewed
Sep 3, 2024
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
Sep 3, 2024
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
Will-ShaoHua
reviewed
Sep 9, 2024
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
manodnyab
reviewed
Sep 10, 2024
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
Sep 10, 2024
...ains-community/src/software/aws/toolkits/jetbrains/services/cwc/controller/ChatController.kt
Outdated
Show resolved
Hide resolved
Will-ShaoHua
approved these changes
Sep 10, 2024
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/startup/AmazonQStartupActivity.kt
Show resolved
Hide resolved
rli
reviewed
Sep 11, 2024
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/startup/AmazonQStartupActivity.kt
Outdated
Show resolved
Hide resolved
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/startup/AmazonQStartupActivity.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
Sep 11, 2024
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/startup/AmazonQStartupActivity.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
Sep 11, 2024
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/startup/AmazonQStartupActivity.kt
Outdated
Show resolved
Hide resolved
rli
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
In the current release, the
workspace
indexing only starts when user inputworkspace
in the chat window, which will fail the first query withworkspace
for customers because the service is not ready customer will still see responses that is not context aware. This is a bug and in VS Code Amazon Q we do not have such bug, the indexing starts when a new project is opened.The solution is to start the
workspace
indexing when user opens a new project with a small delay and conditions. We are aware of the native intelliJ indexing and other possible CPU heavy computation when JetBrains loads a new project, so we added conditions to wait until the CPU usage is low enough to doworkspace
indexing without slowing down the device.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.