Skip to content

feat(amazonq): use detector library url from server #4873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Sep 10, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Improvement to use detector library url from server, otherwise if null then show -

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ctlai95 ctlai95 requested a review from a team as a code owner September 10, 2024 21:40
val detectorLibraryLink = if (issue.recommendation.url != null) {
"<a href=\"${issue.recommendation.url}\">${issue.detectorName}</a>"
} else {
"-"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is - or N/A better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used - since we are already doing that for cwes field above

…/aws/toolkits/jetbrains/services/codewhisperer/codescan/listeners/CodeWhispererCodeScanEditorMouseMotionListener.kt

Co-authored-by: Richard Li <742829+rli@users.noreply.github.com>
@rli rli merged commit c0bd5f6 into aws:main Sep 11, 2024
7 of 10 checks passed
@ctlai95 ctlai95 deleted the detector-library-url branch September 11, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants