Skip to content

Updated AuthTelemetry.addConnection telemetry event to Telemetry.auth.addConnection #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

LokeshDogga13
Copy link
Contributor

@LokeshDogga13 LokeshDogga13 commented Feb 7, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Previously Authtelemetry which was being used is deprecated. I have added changes to use the new telemetry event which will now log both trace id and parent id.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LokeshDogga13 LokeshDogga13 requested a review from a team as a code owner February 7, 2025 00:24
Copy link

github-actions bot commented Feb 7, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@LokeshDogga13 LokeshDogga13 changed the title Updated AddConnection telemetry event in LoginBrowser.kt Updated AddConnection telemetry event Feb 7, 2025
@rli rli self-requested a review February 10, 2025 19:37
@rli
Copy link
Contributor

rli commented Feb 10, 2025

please fix the PR title and description

@LokeshDogga13 LokeshDogga13 changed the title Updated AddConnection telemetry event Updated AuthTelemetry.addConnection telemetry event to Telemetry.auth.addConnection Feb 11, 2025
@LokeshDogga13 LokeshDogga13 enabled auto-merge (squash) February 11, 2025 06:22
@LokeshDogga13 LokeshDogga13 force-pushed the lodogga/telemetryRefactor branch from 1037ea1 to 1732951 Compare February 11, 2025 21:21
@LokeshDogga13 LokeshDogga13 merged commit 8c69af2 into main Feb 11, 2025
2 of 10 checks passed
@LokeshDogga13 LokeshDogga13 deleted the lodogga/telemetryRefactor branch February 11, 2025 21:22
samgst-amazon pushed a commit that referenced this pull request Feb 12, 2025
….addConnection (#5338)

* Updated AddConnection telemetry event in LoginBrowser.kt

* Updated AddConnection telemetry event

* Fixed issues using gradlew detekt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants