Skip to content

feat(amazonq): initialize flare lsp on project start #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

rli
Copy link
Contributor

@rli rli commented Feb 12, 2025

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rli rli requested review from a team as code owners February 12, 2025 17:09
Copy link

github-actions bot commented Feb 12, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

}
}

private class AmazonQServerInstance(cs: CoroutineScope) : Disposable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pass in private val project here? I was using it for workspace folders -- unless there is a better way to be doing so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

 Conflicts:
	plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
@rli rli merged commit d9f7bb3 into feature/q-lsp Feb 13, 2025
9 of 12 checks passed
@rli rli deleted the rli/lsp-start branch February 13, 2025 00:54
leigaol pushed a commit to leigaol/aws-toolkit-jetbrains that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants