Skip to content

Revert "feat(amazonq): Prefetch next inline recommendation (#5290)" #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

evanliu048
Copy link
Contributor

@evanliu048 evanliu048 commented Feb 12, 2025

This reverts commit 805cb39.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

In the previous change, we applied prefect to every responses. However, this introduced issues with inline completion, causing it to behave inconsistently and produce unexpected completions in the next response.

To mitigate this, this PR rolls back the responses prefect change to restore stable inline completion behavior.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@evanliu048 evanliu048 requested a review from a team as a code owner February 12, 2025 20:09
@evanliu048 evanliu048 marked this pull request as draft February 12, 2025 20:09
@evanliu048 evanliu048 marked this pull request as ready for review February 12, 2025 23:02
@evanliu048 evanliu048 requested a review from a team as a code owner February 13, 2025 00:45
@rli rli merged commit 68a179a into aws:main Feb 13, 2025
2 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants