Skip to content

refactor(amazonq): improve error handling of workspace index #5373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2025

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented Feb 13, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Improve error handling of workspace index:

  1. Log error when no file is found in the workspace for indexing.
  2. Do not send LSP messages if the language server has not started.

These 2 are not customer facing changes.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner February 13, 2025 18:54
@leigaol leigaol requested a review from Will-ShaoHua February 13, 2025 18:54
@leigaol
Copy link
Contributor Author

leigaol commented Feb 13, 2025

I am fixing unit tests

@Will-ShaoHua
Copy link
Contributor

@leigaol let's not merge it until release is done

@leigaol leigaol requested a review from a team as a code owner February 13, 2025 22:12
@leigaol leigaol merged commit 3621194 into aws:main Feb 14, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants