Skip to content

feat(amazonq): add virtualFile -> URI util #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 3, 2025

Conversation

samgst-amazon
Copy link
Contributor

Add util for VirtualFile -> URI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Utilize existing util packages for some case handling, we can add edge case logic inside this function.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon requested a review from a team as a code owner February 15, 2025 02:22
Copy link

github-actions bot commented Feb 15, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@samgst-amazon samgst-amazon changed the title add virtualFile -> URI util feat(amazonq): add virtualFile -> URI util Feb 18, 2025
@samgst-amazon
Copy link
Contributor Author

/retryBuilds

@samgst-amazon samgst-amazon merged commit 1fd1e73 into feature/q-lsp Mar 3, 2025
4 of 13 checks passed
@samgst-amazon samgst-amazon deleted the samgst/lsp-fileUtil branch March 3, 2025 19:13
leigaol pushed a commit to leigaol/aws-toolkit-jetbrains that referenced this pull request Mar 20, 2025
* add virtualFile -> URI util

* add string function

* utility object instead of class

* tests

* detekt

* detekt

* redhat impl

* deteckt

* missing license

* fix tests

* detekt

* OS handling for tests

* detekt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants