Skip to content

revert(amazonq): pr #5331 broke tests by throwing NotAMock #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Feb 18, 2025

Description

Revert "refactor(Q tech debt): make cwsprClientAdapr stateless and obtain sdk client from AwsClientManager (#5331)"

This reverts commit 4971993.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

…tain sdk client from AwsClientManager (aws#5331)"

This reverts commit 4971993.
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner February 18, 2025 00:28
@Will-ShaoHua Will-ShaoHua changed the title Revert "refactor(Q tech debt): make cwsprClientAdapr stateless and ob… revert(amazonq): pr #5331 broke tests by throwing NotAMock Feb 18, 2025
@rli rli merged commit fd7eb31 into aws:main Feb 18, 2025
9 of 14 checks passed
@Will-ShaoHua Will-ShaoHua deleted the revert branch February 18, 2025 02:16
Will-ShaoHua added a commit to Will-ShaoHua/aws-toolkit-jetbrains that referenced this pull request Mar 18, 2025
Will-ShaoHua added a commit that referenced this pull request Mar 20, 2025
* Revert "revert(amazonq): pr #5331 broke tests by throwing NotAMock (#5383)"

This reverts commit fd7eb31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants