ci: Update UI tests to use the 243 release #5388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/runUiTests |
rli
reviewed
Feb 19, 2025
...arter/tst-243+/software/aws/toolkits/jetbrains/uitests/OfflineAmazonQInlineCompletionTest.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
Feb 19, 2025
...er/tst-241-242/software/aws/toolkits/jetbrains/uitests/OfflineAmazonQInlineCompletionTest.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
Feb 19, 2025
| @@ -28,6 +30,7 @@ class OfflineAmazonQInlineCompletionTest { | |||
| di = DI { | |||
| extend(di) | |||
| bindSingleton<CIServer>(overrides = true) { TestCIServer } | |||
| ConfigurationStorage.Companion.logEnvironmentVariables(false) | |||
There was a problem hiding this comment.
we should override the defaults so reset() does not flip this back
There was a problem hiding this comment.
I tried doing that but the ConfigurationStorage class which has the default values cannot be directly inherited from...
There was a problem hiding this comment.
try
val defaults = ConfigurationStorage.instance().defaults.toMutableMap().apply {
put("LOG_ENVIRONMENT_VARIABLES", "false")
}
bindSingleton<ConfigurationStorage>(overrides = true) {
ConfigurationStorage(this, defaults)
}
There was a problem hiding this comment.
Yep, sorry, I could access the vars only in 243, I think I was trying in 242 earlier. The var is public
rli
reviewed
Feb 19, 2025
...arter/tst-243+/software/aws/toolkits/jetbrains/uitests/OfflineAmazonQInlineCompletionTest.kt
Outdated
Show resolved
Hide resolved
manodnyab
changed the title
|
/runUiTests |
rli
approved these changes
Feb 19, 2025
|
/runUiTests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.