refactor(amazonq): stateless Q client #5481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
commented
Mar 19, 2025
| @@ -114,7 +114,6 @@ class CodeWhispererSettingsTest : CodeWhispererTestBase() { | |||
| } ?: fail("CodeWhisperer status bar widget not found") | |||
|
|
|||
| runInEdtAndWait { | |||
| assertThat(problemsWindow.contentManager.contentCount).isEqualTo(0) | |||
There was a problem hiding this comment.
seems to be flaky, sometimes it will be 1 with code scan sometimes not.
|
/retryBuilds |
andrewyuq
approved these changes
Mar 19, 2025
rli
approved these changes
Mar 20, 2025
...ware/aws/toolkits/jetbrains/services/codewhisperer/credentials/CodeWhispererClientAdaptor.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5383
Description
There is no need to store a client as a state within this class, AwsClientManager already handle the connection change
resolve comments #5290 (comment)
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.