-
Notifications
You must be signed in to change notification settings - Fork 262
feat(lsp): respect IDE user proxy settings / forward trust store #5553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
82f7313
cf0ba75
b8dcb4d
0f73bf6
3328c9f
8b08e5c
92e93b4
548fa25
ed5f0c8
57ecb8b
fb46994
c243301
37fd987
a7e7872
2276592
ecf1779
190427f
1644d96
9fd2e21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,144 @@ | ||
// Copyright 2025 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package software.aws.toolkits.jetbrains.services.amazonq.lsp | ||
|
||
import com.intellij.util.io.DigestUtil | ||
import com.intellij.util.net.JdkProxyProvider | ||
import com.intellij.util.net.ssl.CertificateManager | ||
import org.apache.http.client.methods.RequestBuilder | ||
import org.apache.http.conn.ssl.DefaultHostnameVerifier | ||
import org.apache.http.impl.client.HttpClientBuilder | ||
import org.apache.http.impl.client.SystemDefaultCredentialsProvider | ||
import org.apache.http.impl.conn.SystemDefaultRoutePlanner | ||
import org.jetbrains.annotations.TestOnly | ||
import software.aws.toolkits.core.utils.getLogger | ||
import software.aws.toolkits.core.utils.warn | ||
import java.net.URI | ||
import java.security.KeyStore | ||
import java.security.cert.CertPathBuilder | ||
import java.security.cert.CertStore | ||
import java.security.cert.Certificate | ||
import java.security.cert.CollectionCertStoreParameters | ||
import java.security.cert.PKIXBuilderParameters | ||
import java.security.cert.PKIXCertPathBuilderResult | ||
import java.security.cert.X509CertSelector | ||
import java.security.cert.X509Certificate | ||
import java.util.Base64 | ||
import kotlin.collections.ifEmpty | ||
|
||
object TrustChainUtil { | ||
|
||
private val LOG = getLogger<TrustChainUtil>() | ||
Check warning on line 31 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
@TestOnly | ||
fun resolveTrustChain(certs: Collection<X509Certificate>, trustAnchors: Collection<X509Certificate>) = resolveTrustChain( | ||
certs, | ||
keystoreFromCertificates(trustAnchors) | ||
) | ||
Check warning on line 37 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
/** | ||
* Build and validate the complete certificate chain | ||
* @param certs The end-entity certificate | ||
* @param trustAnchors The truststore containing trusted CA certificates | ||
* @return The complete certificate chain | ||
*/ | ||
fun resolveTrustChain(certs: Collection<X509Certificate>, trustAnchors: KeyStore): List<X509Certificate> { | ||
|
||
try { | ||
Check warning on line 46 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
// Create the selector for the certificate | ||
val selector = X509CertSelector() | ||
selector.certificate = certs.first() | ||
Check warning on line 49 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
// Create the parameters for path validation | ||
val pkixParams = PKIXBuilderParameters(trustAnchors, selector) | ||
Check warning on line 52 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
// Disable CRL checking since we just want to build the path | ||
pkixParams.isRevocationEnabled = false | ||
Check warning on line 55 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
// Create a CertStore containing the certificate we want to validate | ||
val ccsp = CollectionCertStoreParameters(certs) | ||
val certStore = CertStore.getInstance("Collection", ccsp) | ||
pkixParams.addCertStore(certStore) | ||
Check warning on line 60 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
// Get the certification path | ||
val builder = CertPathBuilder.getInstance("PKIX") | ||
val result = builder.build(pkixParams) as PKIXCertPathBuilderResult | ||
val certPath = result.certPath | ||
val chain = (certPath.certificates as List<X509Certificate>).toMutableList() | ||
Check warning on line 66 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
// Add the trust anchor (root CA) to complete the chain | ||
val trustAnchorCert = result.trustAnchor.trustedCert | ||
Check warning on line 69 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
if (trustAnchorCert != null) { | ||
chain.add(trustAnchorCert) | ||
Check warning on line 71 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
} | ||
|
||
return chain | ||
} catch (e: Exception) { | ||
Check warning on line 75 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
// Java PKIX is happy with leaf cert in certification path, but Node.JS will not respect in NODE_CA_CERTS | ||
LOG.warn(e) { "Could not build trust anchor via CertPathBuilder? maybe user accepted leaf cert but not intermediate" } | ||
Check warning on line 77 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
return emptyList() | ||
Check warning on line 79 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
} | ||
} | ||
|
||
fun getTrustChain(uri: URI): List<X509Certificate> { | ||
|
||
val proxyProvider = JdkProxyProvider.getInstance() | ||
var peerCerts: Array<Certificate> = emptyArray() | ||
val verifierDelegate = DefaultHostnameVerifier() | ||
val client = HttpClientBuilder.create() | ||
.setRoutePlanner(SystemDefaultRoutePlanner(proxyProvider.proxySelector)) | ||
.setDefaultCredentialsProvider(SystemDefaultCredentialsProvider()) | ||
.setSSLHostnameVerifier { hostname, sslSession -> | ||
peerCerts = sslSession.peerCertificates | ||
Check warning on line 91 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
verifierDelegate.verify(hostname, sslSession) | ||
Check warning on line 93 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
} | ||
// prompt user via modal to accept certificate if needed; otherwise need to prompt separately prior to launching flare | ||
.setSSLContext(CertificateManager.getInstance().sslContext) | ||
Check warning on line 96 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
// client request will fail if user did not accept cert | ||
client.build().use { it.execute(RequestBuilder.options(uri).build()) } | ||
Check warning on line 99 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
val certificates = peerCerts as Array<X509Certificate> | ||
Check warning on line 101 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
// java default + custom system | ||
// excluding leaf cert for case where user has both leaf and issuing CA as trusted roots | ||
val allAccepted = CertificateManager.getInstance().trustManager.acceptedIssuers.toSet() - certificates.first() | ||
val ks = keystoreFromCertificates(allAccepted) | ||
Check warning on line 106 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
// if this throws then there is a bug because it passed PKIX validation in apache client | ||
val trustChain = try { | ||
resolveTrustChain(certificates.toList(), ks) | ||
} catch (e: Exception) { | ||
Check warning on line 111 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
// Java PKIX is happy with leaf cert in certification path, but Node.JS will not respect in NODE_CA_CERTS | ||
LOG.warn(e) { "Passed Apache PKIX verification but could not build trust anchor via CertPathBuilder? maybe user accepted leaf cert but not root" } | ||
emptyList() | ||
Check warning on line 114 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
} | ||
|
||
// if trust chain is empty, then somehow user only trusts the leaf cert??? | ||
return trustChain.ifEmpty { | ||
// so return the served certificate chain from the server and hope that works | ||
certificates.toList() | ||
Check warning on line 120 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
} | ||
} | ||
|
||
fun certsToPem(certs: List<X509Certificate>): String = | ||
buildList { | ||
certs.forEach { | ||
add("-----BEGIN CERTIFICATE-----") | ||
add(Base64.getMimeEncoder(64, System.lineSeparator().toByteArray()).encodeToString(it.encoded)) | ||
add("-----END CERTIFICATE-----") | ||
} | ||
}.joinToString(separator = System.lineSeparator()) | ||
Check warning on line 131 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
|
||
private fun keystoreFromCertificates(certificates: Collection<X509Certificate>): KeyStore { | ||
val ks = KeyStore.getInstance(KeyStore.getDefaultType()) | ||
ks.load(null, null) | ||
certificates.forEachIndexed { index, cert -> | ||
ks.setCertificateEntry( | ||
cert.subjectX500Principal.toString() + "-" + DigestUtil.sha256Hex(cert.encoded), | ||
cert | ||
Check warning on line 139 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
) | ||
} | ||
return ks | ||
Check warning on line 142 in plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/TrustChainUtil.kt
|
||
} | ||
} |
Uh oh!
There was an error while loading. Please reload this page.