fix(amazonq): switch to ulong to avoid overflow when input is larger than 2gb #5558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than 2gb 2GB in bytes > INT_MAX so use ULong, which can handle 18 PB
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Will-ShaoHua
approved these changes
Apr 11, 2025
…ss fails to start" This reverts commit 93ca253.
manodnyab
approved these changes
Apr 15, 2025
| @@ -353,5 +301,58 @@ class ProjectContextProvider(val project: Project, private val encoderServer: En | |||
|
|
|||
| companion object { | |||
| private val logger = getLogger<ProjectContextProvider>() | |||
| private val regex = Regex("""bin|build|node_modules|venv|\.venv|env|\.idea|\.conda""", RegexOption.IGNORE_CASE) | |||
There was a problem hiding this comment.
Not a blocker, but do we want to move this list to a common utils file
There was a problem hiding this comment.
everyone seems to have a different concept of what to ignore at the moment
| } | ||
| if (file.isFile) { | ||
| allFiles.add(file) | ||
| return false |
There was a problem hiding this comment.
files have no children to visit so it could go either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2GB in bytes > INT_MAX
so use ULong, which can handle 18 PB
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.