Skip to content

feat(amazonq): client emits endChat when conversation ended #5572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from

Conversation

samgst-amazon
Copy link
Contributor

Handles the endChat command

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Handle "aws/chat/endChat" by sending the server a request and removing the tab from the ChatPartialResultMap if present.

Implemented with changes from: #5561
EndChat is not currently hooked up on FLARE side, so this may need to change depending on how they implement it:
aws/language-servers#433

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

manodnyab and others added 23 commits April 9, 2025 12:07
…Flare' into manodnyb/setupChatComponentsWithFlare
…Flare' into manodnyb/setupChatComponentsWithFlare
…p-endChat

# Conflicts:
#	plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
…tions' into samgst/q-lsp-endChat

# Conflicts:
#	plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
#	plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageServer.kt
#	plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/FlareChatCommands.kt
@samgst-amazon samgst-amazon requested review from a team as code owners April 14, 2025 18:57
Copy link

Qodana Community for JVM

3 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 2
Unused import directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@@ -17,6 +17,7 @@
import kotlinx.coroutines.flow.launchIn
import kotlinx.coroutines.flow.merge
import kotlinx.coroutines.flow.onEach
import kotlinx.coroutines.future.await

Check warning

Code scanning / QDJVMC

Unused import directive Warning

Unused import directive

fun getAwsServerCapabilities(): AwsServerCapabilities? = awsServerCapabilities

fun setAwsServerCapabilities(awsServerCapabilities: AwsServerCapabilities?) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Function "setAwsServerCapabilities" is never used
val tabId: String,
)

data class EndChatResult(

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "EndChatResult" is never used
@samgst-amazon samgst-amazon changed the title Samgst/q lsp end chat feat(amazonq): client emits endChat when conversation ended Apr 14, 2025
@samgst-amazon samgst-amazon changed the base branch from feature/q-lsp-chat to manodnyb/addQuickActions April 15, 2025 16:28
Base automatically changed from manodnyb/addQuickActions to feature/q-lsp-chat April 21, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants