-
Notifications
You must be signed in to change notification settings - Fork 251
fix(amazonq): Invalidate Obsolete Customization on Profile Switch #5575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/profile/QRegionProfileManager.kt
# Conflicts: # plugins/core/sdk-codegen/codegen-resources/codewhispererstreaming/service-2.json
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Fixed
Show fixed
Hide fixed
manodnyab
approved these changes
Apr 15, 2025
manodnyab
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add a changelog?
Will-ShaoHua
approved these changes
Apr 15, 2025
Merged
6 tasks
rli
pushed a commit
that referenced
this pull request
Apr 21, 2025
…f an Idc connection (#5591) Follow-up to #5575. As mentioned in that PR: Before: Customizations were bound to a specific IDC instance. After: Customizations are now bound to a specific Q profile. An IDC instance can have multiple Q profiles. In other words, each Q profile has access to its own set of customizations. The product team has requested that we show all available customizations across profiles, rather than only those tied to the currently connected profile. This means that when a user selects a customization that belongs to a different Q profile, the plugin should implicitly switch to that profile. This behavior helps reduce confusion and user churn, since users might not clearly understand which profile grants access to which customizations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
When a user switches profiles, the active customization is now verified against the updated list of available customizations.
If the active customization is not present in the newly returned list, it is automatically invalidated.
This change ensures consistency between the user's profile and the customizations applied.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.