fix(amazonq): support displaying customizations across all profiles of an Idc connection #5591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/profile/QRegionProfileManager.kt
# Conflicts: # plugins/core/sdk-codegen/codegen-resources/codewhispererstreaming/service-2.json
# Conflicts: # plugins/core/sdk-codegen/codegen-resources/codewhispererstreaming/service-2.json
rli
reviewed
Apr 18, 2025
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Outdated
Show resolved
Hide resolved
...re/aws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererCustomization.kt
Show resolved
Hide resolved
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/profile/QRegionProfileManager.kt
Outdated
Show resolved
Hide resolved
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/profile/QRegionProfileManager.kt
Show resolved
Hide resolved
...mmunity/src/software/aws/toolkits/jetbrains/services/amazonq/profile/QProfileSwitchIntent.kt
Outdated
Show resolved
Hide resolved
.../toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererCustomizationDialog.kt
Show resolved
Hide resolved
.../toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererCustomizationDialog.kt
Show resolved
Hide resolved
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Outdated
Show resolved
Hide resolved
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Outdated
Show resolved
Hide resolved
...ws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Outdated
Show resolved
Hide resolved
Will-ShaoHua
approved these changes
Apr 21, 2025
rli
approved these changes
Apr 21, 2025
rli
reviewed
Apr 21, 2025
| @@ -12,4 +13,7 @@ data class CodeWhispererCustomization( | |||
|
|
|||
| @JvmField | |||
| var description: String? = null, | |||
|
|
|||
| @JvmField | |||
There was a problem hiding this comment.
do we remember why these need to be fields?
There was a problem hiding this comment.
I followed the style of other fields in the file. It might be good to check with @Will-ShaoHua or @manodnyab in case they have more context on why this pattern is used.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5575.
As mentioned in that PR:
Before: Customizations were bound to a specific IDC instance.
After: Customizations are now bound to a specific Q profile. An IDC instance can have multiple Q profiles.
In other words, each Q profile has access to its own set of customizations.
Types of changes
Description
The product team has requested that we show all available customizations across profiles, rather than only those tied to the currently connected profile.
This means that when a user selects a customization that belongs to a different Q profile, the plugin should implicitly switch to that profile. This behavior helps reduce confusion and user churn, since users might not clearly understand which profile grants access to which customizations.
Summary of Changes
- Display all customizations across profiles.
Screen.Recording.2025-04-20.at.11.56.42.PM.mov
- Change profile should validate if the selected customization is under the new profile or not
Screen.Recording.2025-04-20.at.11.57.08.PM.mov
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.