deps(flare): Add registry entry for flare manifest endpoint #5610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
manodnyab
changed the title
rli
reviewed
Apr 21, 2025
rli
reviewed
May 20, 2025
Comment on lines
+32
to
+37
| private val DEFAULT_MANIFEST_URL = getManifestEndpoint() | ||
|
|
||
| private fun getManifestEndpoint(): String { | ||
| val endpoint = Registry.get("amazon.q.flare.endpoint").asString() | ||
| return endpoint.ifBlank { "https://aws-toolkit-language-servers.amazonaws.com/qAgenticChatServer/0/manifest.json" } | ||
| } |
There was a problem hiding this comment.
value will be read on class init
Suggested change
| private val DEFAULT_MANIFEST_URL = getManifestEndpoint() | |
| private fun getManifestEndpoint(): String { | |
| val endpoint = Registry.get("amazon.q.flare.endpoint").asString() | |
| return endpoint.ifBlank { "https://aws-toolkit-language-servers.amazonaws.com/qAgenticChatServer/0/manifest.json" } | |
| } | |
| private val DEFAULT_MANIFEST_URL | |
| get() = getManifestEndpoint() | |
| private fun getManifestEndpoint(): String { | |
| val endpoint = Registry.get("amazon.q.flare.endpoint").asString() | |
| return endpoint.ifBlank { "https://aws-toolkit-language-servers.amazonaws.com/qAgenticChatServer/0/manifest.json" } | |
| } |
should probably just delete DEFAULT_MANIFEST_URL and only use the method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.