fix(amazonq): Ensure active customization has profile filled to support proper validation #5611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/profile/QRegionProfileManager.kt
# Conflicts: # plugins/core/sdk-codegen/codegen-resources/codewhispererstreaming/service-2.json
# Conflicts: # plugins/core/sdk-codegen/codegen-resources/codewhispererstreaming/service-2.json
# Conflicts: # plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
# Conflicts: # plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/customization/CodeWhispererModelConfigurator.kt
Contributor
Author
|
Let's revert this change for now. We're not 100% confident it won't cause further regressions—especially since we're already seeing throttling and usage drop. The team wants to prioritize the first two issues before revisiting customization. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug introduced by #5591.
Types of changes
Description
This PR addresses an edge case where
activeCustomization.profileis null, which causes the plugin to skip the invalidation logic due to the current conditional check.This situation might occur for legacy users whose selected customizations were saved before the profile field was introduced. If the profile is missing, the plugin now attempts to recover the profile by matching the arn from the aggregated customization list.
In the profile validation logic (step 4), added a fallback mechanism:
If activeCustomization.profile == null, search the fetched list for a matching arn and backfill the profile.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.