Skip to content

fix(amazonq): Enable stop button of chat #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 6, 2025

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented May 5, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
stop_resp.mov

Description

Enable the stop chat button. Ref: https://github.com/aws/amazon-q-eclipse/blob/main/plugin/src/software/aws/toolkits/eclipse/amazonq/chat/ChatMessageProvider.java#L108-L114

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners May 5, 2025 23:47
@leigaol leigaol marked this pull request as draft May 5, 2025 23:47
@leigaol leigaol marked this pull request as ready for review May 6, 2025 00:01
@leigaol
Copy link
Contributor Author

leigaol commented May 6, 2025

CI failure is not relevant to this PR

@manodnyab
Copy link
Contributor

/retryBuilds

@Will-ShaoHua Will-ShaoHua self-requested a review May 6, 2025 21:07
@@ -38,6 +38,7 @@ action.aws.toolkit.toolwindow.newConnection.text=Add Another Connection...
action.dynamic.open.text=Open Resource...
action.q.openchat.text=Open Chat Panel
amazonqChat.project_context.index_in_progress=By the way, I'm still indexing this project for full context from your workspace. I may have a better response in a few minutes when it's complete if you'd like to try again then.
amazonqChat.stopChatResponse=You stopped your current work, please provide additional examples or ask another question.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use amazonq bundle instead @leigaol

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AmazonQBundle.properties

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of new messages checked in the core bundle... I was following previous commits.

Can do as a fast follow. This needs to go in for today's bug bash. I have 2nd PR depending on this!

@manodnyab manodnyab merged commit fdcae23 into aws:feature/q-lsp-chat May 6, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants