feat(amazonq): clicking on changed file in Q chat opens up file diff in editor #5675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVM2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -42,6 +46,9 @@ | |||
| import software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.credentials.SsoProfileData | |||
| import software.aws.toolkits.jetbrains.services.codewhisperer.customization.CodeWhispererModelConfigurator | |||
| import software.aws.toolkits.jetbrains.settings.CodeWhispererSettings | |||
| import software.aws.toolkits.resources.message | |||
Check warning
Code scanning / QDJVMC
Usage of redundant or deprecated syntax or deprecated symbols Warning
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Fixed
Show fixed
Hide fixed
| } | ||
| } | ||
| val diffRequest = SimpleDiffRequest( | ||
| "$fileName ${message("aws.q.lsp.client.diff_message")}", |
Check warning
Code scanning / QDJVMC
Usage of redundant or deprecated syntax or deprecated symbols Warning
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Fixed
Show fixed
Hide fixed
manodnyab
reviewed
May 6, 2025
| @@ -262,6 +269,45 @@ class AmazonQLanguageClientImpl(private val project: Project) : AmazonQLanguageC | |||
| return CompletableFuture.completedFuture(Unit) | |||
| } | |||
|
|
|||
| override fun openFileDiff(params: OpenFileDiffParams): CompletableFuture<Unit> = | |||
| CompletableFuture.supplyAsync({ | |||
| ApplicationManager.getApplication().invokeLater { | |||
There was a problem hiding this comment.
can we follow the same pattern: #5663 (comment)?
manodnyab
reviewed
May 6, 2025
| LOG.warn { "Failed to open file diff: ${e.message}" } | ||
| } | ||
| } | ||
| Unit |
manodnyab
approved these changes
May 6, 2025
rli
approved these changes
May 6, 2025
| @@ -262,6 +269,45 @@ class AmazonQLanguageClientImpl(private val project: Project) : AmazonQLanguageC | |||
| return CompletableFuture.completedFuture(Unit) | |||
| } | |||
|
|
|||
| override fun openFileDiff(params: OpenFileDiffParams): CompletableFuture<Unit> = | |||
| CompletableFuture.supplyAsync( | |||
There was a problem hiding this comment.
we should figure out how to move this onto coroutines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle aws/openFileDiff notifications.
When user clicks a filename in Q chat, the file diff opens up in the editor:
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.