fix(amazonq): update diff view with syntax highlights and proper new file view #5679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
…howDiffWithHighlighting # Conflicts: # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt # plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/FlareChatCommands.kt
rli
reviewed
May 7, 2025
| val (leftContent, rightContent) = when { | ||
| params.isDeleted -> { | ||
| // For deleted files, show original on left, empty on right | ||
| contentFactory.create(originalContent) to | ||
| contentFactory.create(originalContent, virtualFile) to |
There was a problem hiding this comment.
create has an option for file type, so i think we can keep this in memory and avoid the temp file
There was a problem hiding this comment.
I tried that earlier and wasn't seeing the highlighting being applied. Agree that avoiding the temp file would be ideal. I'll try again
There was a problem hiding this comment.
i think you should also pass in the project as a parameter so it's taking dependencies into account?
samgst-amazon
changed the title
rli
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the diff in the chat now shows syntax highlighting in the diff view
Q creating a new file now shows only the new file in the diff view
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.