Skip to content

fix(amazonq): Add error handling of agentic chat #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 7, 2025

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented May 6, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Fix of https://github.com/aws/aws-toolkit-jetbrains/pull/5571/files#diff-cd56bad1ef35b0dcfb5c729a7b22594c1b15f8fa64d7be9743bb125c5e4f7c1dR99

Screenshot 2025-05-06 at 4 49 48 PM

I manually added exception in showResult

if (messageToChat.contains("abc")) {
                    throw Exception("abc err")
                }

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners May 6, 2025 23:15
@leigaol leigaol marked this pull request as draft May 6, 2025 23:16
@leigaol leigaol changed the title fix(amazonq): Add error handling of agentic chat WIP fix(amazonq): Add error handling of agentic chat May 6, 2025
@leigaol leigaol changed the title WIP fix(amazonq): Add error handling of agentic chat fix(amazonq): Add error handling of agentic chat May 6, 2025
@leigaol leigaol marked this pull request as ready for review May 6, 2025 23:51
@leigaol leigaol marked this pull request as draft May 6, 2025 23:53
@leigaol leigaol marked this pull request as ready for review May 7, 2025 00:05
@rli rli merged commit 4dc770f into aws:feature/q-lsp-chat May 7, 2025
10 of 12 checks passed
@manodnyab manodnyab mentioned this pull request May 9, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants