fix(amazonq): fix lsp warning about unsupported 'aws/chat/sendContextCommands' #5692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
manodnyab
reviewed
May 8, 2025
| @@ -308,6 +310,19 @@ class AmazonQLanguageClientImpl(private val project: Project) : AmazonQLanguageC | |||
| ApplicationManager.getApplication()::invokeLater | |||
| ) | |||
|
|
|||
| override fun sendContextCommands(params: LSPAny): CompletableFuture<Unit> { | |||
| val showContextCommands = """ | |||
| { | |||
There was a problem hiding this comment.
We have a util for this ChatCommunicationManager.convertNotificationToJsonForChat
There was a problem hiding this comment.
i dont like that pattern
#5693
samgst-amazon
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifications should be registered in the LanguageClient instead of being handled in the message wrapper
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.