fix(amazonq): do not model types that are directly passthrough to chat ui #5702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rli merged 9 commits into feature/q-lsp-chat from rli/fix-history-restore

May 9, 2025

Contributor

rli commented May 9, 2025

Due to mix of Jackson and Gson, history is not rendered correctly due to incorrect deserialization of enums

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.


          fix(amazonq): do not model types that are directly passthrough to cha…

4af9d17

…t ui

Due to mix of Jackson and Gson, history is not rendered correctly due to incorrect deserialization of enums

rli requested review from a team as code owners

May 9, 2025 00:55


          Merge remote-tracking branch 'origin/feature/q-lsp-chat' into rli/fix…

bfad5e1

…-history-restore

 Conflicts:
	plugins/amazonq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt

github-actions bot commented May 9, 2025 •

edited

Loading

Qodana Community for JVM

21 new problems were found

Inspection name	Severity	Problems
`Unused symbol`	🔶 Warning	21

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions


          lint

855afd6

manodnyab approved these changes

View reviewed changes

rli and others added 2 commits

May 9, 2025 11:37

tst

4d99a80


          Merge branch 'feature/q-lsp-chat' into rli/fix-history-restore

34efb26

github-advanced-security bot found potential problems

View reviewed changes

...c/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/AuthFollowUpClicked.kt

-              enum class AuthFollowupType(val value: String) {
+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class AuthFollowupType(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "repr" is never used

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt

-                  @JsonProperty("calendar")
-                  CALENDAR,
+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class IconType(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "repr" is never used

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt

+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class IconType(@JsonValue val repr: String) {
+                  FILE("file"),
+                  FOLDER("folder"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "FOLDER" is never used

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt

+                  FILE("file"),
+                  FOLDER("folder"),
+                  CODE_BLOCK("code-block"),
+                  LIST_ADD("list-add"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "LIST_ADD" is never used

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt Fixed Show fixed Hide fixed

...ity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/Conversations.kt Fixed Show fixed Hide fixed

...ftware/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/GetSerializedChatParams.kt Fixed Show fixed Hide fixed

...ftware/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/GetSerializedChatParams.kt Fixed Show fixed Hide fixed

...rc/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/TabBarActionParams.kt Fixed Show fixed Hide fixed

...rc/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/TabBarActionParams.kt Fixed Show fixed Hide fixed

tst

ebf94f9

github-advanced-security bot found potential problems

View reviewed changes

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt

+                  FOLDER("folder"),
+                  CODE_BLOCK("code-block"),
+                  LIST_ADD("list-add"),
+                  MAGIC("magic"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "MAGIC" is never used

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt

+                  CODE_BLOCK("code-block"),
+                  LIST_ADD("list-add"),
+                  MAGIC("magic"),
+                  HELP("help"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "HELP" is never used

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt

+                  LIST_ADD("list-add"),
+                  MAGIC("magic"),
+                  HELP("help"),
+                  TRASH("trash"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "TRASH" is never used

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt

+                  MAGIC("magic"),
+                  HELP("help"),
+                  TRASH("trash"),
+                  SEARCH("search"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "SEARCH" is never used

...unity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/ChatMessage.kt

+                  HELP("help"),
+                  TRASH("trash"),
+                  SEARCH("search"),
+                  CALENDAR("calendar"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "CALENDAR" is never used

...ity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/Conversations.kt

               }
-              enum class ConversationAction(val value: String) {
+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class ConversationAction(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "repr" is never used

...ftware/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/GetSerializedChatParams.kt

-              enum class SerializedChatFormat(val value: String) {
+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class SerializedChatFormat(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "SerializedChatFormat" is never used

...ftware/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/GetSerializedChatParams.kt

-              enum class SerializedChatFormat(val value: String) {
+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class SerializedChatFormat(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "repr" is never used

...rc/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/TabBarActionParams.kt

-              enum class TabBarAction(val value: String) {
+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class TabBarAction(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "TabBarAction" is never used

...rc/software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/TabBarActionParams.kt

-              enum class TabBarAction(val value: String) {
+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class TabBarAction(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "repr" is never used

rli and others added 3 commits

May 9, 2025 13:12


          Merge branch 'feature/q-lsp-chat' into rli/fix-history-restore

3661d25

tst

1ed1c5e


          Merge remote-tracking branch 'origin/feature/q-lsp-chat' into rli/fix…

c488f60

…-history-restore

github-advanced-security bot found potential problems

View reviewed changes

.../software/aws/toolkits/jetbrains/services/amazonq/lsp/model/aws/chat/GenericCommandParams.kt

               // https://github.com/aws/language-server-runtimes/blob/main/chat-client-ui-types/src/uiContracts.ts#L27
-              enum class TriggerType(val value: String) {
+              @JsonAdapter(EnumJsonValueAdapter::class)
+              enum class TriggerType(@JsonValue val repr: String) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "repr" is never used

rli merged commit 25ee578 into feature/q-lsp-chat

13 of 16 checks passed

rli deleted the rli/fix-history-restore branch

May 9, 2025 21:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet