feat(amazonq): enable client-side build #5704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhasani23
commented
May 9, 2025
| @@ -29,79 +31,20 @@ import java.io.File | |||
| import java.nio.file.Files | |||
| import java.nio.file.Path | |||
|
|
|||
| fun runClientSideBuild(targetDir: VirtualFile, logger: Logger, project: Project): Pair<Int?, String> { | |||
There was a problem hiding this comment.
Moved this to be below. Basically, deleted the unused functions and moved the HIL-related functions to the very bottom of this file since HIL is likely N/A once this feature is released, so can follow up and delete those later.
dhasani23
commented
May 9, 2025
| @@ -300,11 +301,6 @@ data class CodeModernizerSessionContext( | |||
| } | |||
|
|
|||
| LOG.info { "Source code files size = ${files?.sumOf { it.length.toInt() }}" } | |||
|
|
|||
| // 5) Initial Maven copy-deps / install build log | |||
There was a problem hiding this comment.
Unused, no need to include in upload ZIP; update tests accordingly
|
Make sure diff.patch gets parsed correctly from IDE when doing a custom upgrade via YAML (ex. snakeyaml to 2.2) Update: working fine |
dhasani23
force-pushed
the
csbM3
branch
3 times, most recently
from
451c066 to
3f207cb
Compare
added 11 commits
June 19, 2025 16:20
added 2 commits
June 19, 2025 20:59
ntarakad-aws
approved these changes
Jun 20, 2025
rli
reviewed
Jun 23, 2025
plugins/amazonq/build.gradle.kts
Outdated
Comment on lines
29
to
33
| tasks.prepareSandbox { | ||
| from("contrib/QCT-Maven-6-16.jar") { | ||
| into("/plugin-amazonq/lib") | ||
| } | ||
| } |
There was a problem hiding this comment.
can you reuse the block at the end of the file
tasks.withType<PrepareSandboxTask>().configureEach {
[...]
intoChild(intellijPlatform.projectName.map { "$it/lib" })
.from(file("contrib/QCT-Maven-6-16.jar"))
}
rli
reviewed
Jun 23, 2025
Co-authored-by: Richard Li <742829+rli@users.noreply.github.com>
rli
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Execute a JAR client-side to copy the dependencies of the project to the upload ZIP along with some other metadata useful to us for the transformation. Also, enable client-side build by removing the feature flag.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.