fix(amazonq): avoid using modeled types in chat message proxy #5710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a high possibiltiy of drift in our modeling as the UI <-> Server evolves. To avoid a treadmill in making sure these are always up to date, avoid materializing these messages into concrete types
Qodana Community for JVM5 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| val sendChatPrompt = JsonRpcRequest( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| String::class.java | ||
| ) | ||
|
|
||
| val sendQuickAction = JsonRpcRequest( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| Any::class.java | ||
| ) | ||
|
|
||
| val getSerializedActions = JsonRpcRequest( |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| fun <T> executeIfRunning(project: Project, runnable: AmazonQLspService.(AmazonQLanguageServer) -> T): T? = | ||
| project.serviceIfCreated<AmazonQLspService>()?.executeSync(runnable) | ||
|
|
||
| suspend fun <T> asyncExecuteIfRunning(project: Project, runnable: suspend AmazonQLspService.(AmazonQLanguageServer) -> T): T? = |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
manodnyab
approved these changes
May 13, 2025
| val error: OpenTabResultErrorError, | ||
| ) | ||
|
|
||
| data class OpenTabResultErrorError( |
There was a problem hiding this comment.
nit:
Suggested change
| data class OpenTabResultErrorError( | |
| data class OpenTabResultErrorData( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a high possibiltiy of drift in our modeling as the UI <-> Server evolves.
To avoid a treadmill in making sure these are always up to date, avoid materializing these messages into concrete types
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.